Skip to content

[WIP] Run Tests Against Multiple Versions of ASP.Net and EF Core #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

jaredcnance
Copy link
Contributor

@jaredcnance jaredcnance commented Jun 12, 2018

Closes #281

The idea is that for every combination of versions that we choose to explicitly guarantee support for, we will define a new .props file that specifies those versions. The example projects should then import those props files and we run tests against those versions.

The primary package (JsonApiDotNetCore) will continue to import via Directory.Build.props which will define the default build dependencies. This allows us to simulate scenarios such as:

MyApp
├── JsonApiDotNetCore
│        └── AspNetCore v2.0.1
└── AspNetCore v2.1.0

MyApp
├── JsonApiDotNetCore
│        └── AspNetCore v2.1.0
└── AspNetCore v2.0.1

Build is currently failing for the same reason as #300 ... breaking EF Core changes

TODO:

  • Fix failing tests
  • Document how this works and how we upgrade our default dependencies
  • Can we drop /p:NoWarn=NU1605 ?

@jaredcnance
Copy link
Contributor Author

Putting this on hold...can't justify the added complexity at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant