-
-
Notifications
You must be signed in to change notification settings - Fork 158
[draft] Feat/serializer context decoupling #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] Feat/serializer context decoupling #512
Conversation
…ncerns, 12 tests running...
This would also provide a general fix for #251 |
A new controller would like @milosloub What are your thoughts on this? I would say it makes for a more clean and conscise controller with the resources that it needs, and nothing more, allowing for better testability public ArticlesController(
IJsonApiOptions jsonApiOptions,
IResourceGraph resourceGraph,
IResourceService<Article> resourceService)
: base(jsonApiOptions, resourceGraph, resourceService)
{ } |
@wisepotato I have to look more into this. This is really big stuff, I have to spend more time to this. Thanks |
Discussed backward compatibility with @maurei , this will be an afterthought, after fully making what I want I'll try it in one of our V3 projects and see what breaks, and accomodate for that. I'm guessing that's something you would like to see @milosloub 💃 |
Being done in #558 |
The main goal of this PR is to counteract the coupling observed in JADNC. Let's make it more testable!
JsonApiContext
dependency in ControllersResourceGraph
in the middleware nowApplyContext<T>
in the controller, making for a coupling that is not neededBUG FIX
FEATURE