Skip to content

fix: #528 #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

fix: #528 #532

merged 1 commit into from
Jun 21, 2019

Conversation

PiotrBrzezianski
Copy link

Allowing string foreign keys on optional HasOne relationship

Closes #528

BUG FIX

  • reproduce issue in tests
  • fix issue
  • bump package version

fix: json-api-dotnet#528
0bfe81b 
Allowing string foreign keys on optional HasOne relationship
@maurei
Copy link
Member

maurei commented Jun 21, 2019

Looking good, thanks!

@maurei maurei merged commit d490b8b into json-api-dotnet:master Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurei maurei maurei approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SetHasOneForeignKeyValue detects string as non-nullable type and throws exception
2 participants
@PiotrBrzezianski @maurei