feat: use camelCase as default #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisepotato
suggested changes
Nov 7, 2019
| @@ -93,7 +93,7 @@ public virtual async Task<TResource> CreateAsync(TResource entity) | |||
| /// entity when we're using a different instance of the relationship (because this different one | |||
| /// was already tracked) than the one assigned to the to-be-created entity. | |||
| /// Alternatively, even if we don't have to reassign anything because of already tracked | |||
| /// entities, we still need to assign the "through" entities in the case of many-to-many. | |||
| /// entities, we still need to assign the "through" entities in the case of manyToMany. | |||
There was a problem hiding this comment.
the correct word is still many-to-many, or did you go crazy with the camelcasificiation?
| @@ -358,7 +358,7 @@ public async Task<IReadOnlyList<TResource>> ToListAsync(IQueryable<TResource> en | |||
| /// Before assigning new relationship values (UpdateAsync), we need to | |||
| /// attach the current database values of the relationship to the dbcontext, else | |||
| /// it will not perform a complete-replace which is required for | |||
| /// one-to-many and many-to-many. | |||
| @@ -8,7 +8,7 @@ | |||
| namespace JsonApiDotNetCore.Graph | |||
| { | |||
| /// <summary> | |||
| /// Used to locate types and facilitate auto-resource discovery | |||
| /// Used to locate types and facilitate autoResource discovery | |||
| @@ -6,7 +6,7 @@ | |||
| /// </summary> | |||
| public enum ResourceHook | |||
| { | |||
| None, // https://stackoverflow.com/questions/24151354/is-it-a-good-practice-to-add-a-null-or-none-member-to-the-enum | |||
| None, // https://stackoverflow.com/questions/24151354/is-it-a-good-practiceTo-add-a-null-or-noneMemberTo-the-enum | |||
| @@ -107,7 +107,7 @@ public interface IUpdateHookContainer<TResource> where TResource : class, IIdent | |||
| /// hook is fired after the execution of this hook. | |||
| /// <para /> | |||
| /// If by the creation of these relationships, any other relationships (eg | |||
| /// in the case of an already populated one-to-one relationship) are implicitly | |||
| /// in the case of an already populated oneToOne relationship) are implicitly | |||
| @@ -165,7 +165,7 @@ public interface IUpdateHookContainer<TResource> where TResource : class, IIdent | |||
| /// This hook is fired when a relationship to entities of type | |||
| /// <typeparamref name="TResource"/> is implicitly affected from a dependent pipeline (<see cref="ResourcePipeline.Patch"/> | |||
| /// or <see cref="ResourcePipeline.Delete"/>). For example, if an Article was updated | |||
| /// by setting its author relationship (one-to-one) to an existing Person, | |||
| /// by setting its author relationship (oneToOne) to an existing Person, | |||
| _dbContext.SaveChanges(); | ||
| } | ||
|
|
||
| private async Task<(string, HttpResponseMessage)> SendRequest(string method, string route, string content = null) |
There was a problem hiding this comment.
so in general i would suggest a HttpRequest instead of method, route and content, this would make for a more broadly appealing helper class, but this works for now
Merged
wisepotato
pushed a commit
that referenced
this pull request
Nov 11, 2019
* Fix/deviating dbset name (#603) * test: expose dbset name bug * fix: deviating dbset name * chore: add launchSettings.json to gitignore * chore: delete launchSettings.json from git * Fix/pagesize (#601) * feat: new startup for test * chore: rename startup class * test: reproduce #599 in test * fix: zero division error * chore: remove redundant DefaultPageSize on IPageService * chore: update .gitignore * fix: typo LoaDatabaseValues (#608) * fix: typo * fix: typo in fix of typo * chore: enable sql logging in JsonApiDotNetCoreExample * Acceptance tests EF inheritance (#610) * chore: create inheritance model + controller * test: create and patch acceptance test * chore: close issue * Improve usability RequestSerializer (#613) * feat: remove inability to use request serializer with unknown type at runtime * fix: typo in test setup * chore: spacing * fix: add IResourceQueryService and IResourceCmdService to DI container in application builder * chore: update comments IRequestSerializer * Move EF core related building to extension methods (#616) * feat: remove inability to use request serializer with unknown type at runtime * fix: typo in test setup * chore: spacing * fix: add IResourceQueryService and IResourceCmdService to DI container in application builder * chore: update comments IRequestSerializer * chore: moved ef core related building to extension methods * chore: spacing, rename file * refactor: remove need for internal modifier * refactor: minor refactor id type retrieval * Hooks discovery detection of implemented hooks issue (#617) * fix: discovery issue related to assemblies * fix: LoaDatabaseValue typo * fix: set EnableResourceHooks to true by default * chore: add comment in code in hooksdiscovery * fix: use IServiceProvider instead of IScopedServiceProvider * fix: discovery unit test with ServiceProvider instead of ScopedServiceProvider * refactor: TResource instead of TEntity * chore: process PR review * chore: move comment to separate line (stylecop) * feat: use camelCase as default (#618) * feat: use camelCase as default * refactor: massive replace all to replace kebab-case with camelCase default * chore: fix remaining unit tests * fix: fix remaining JsonApiDotNetCoreExampleTests * feat: introduce proper usage of WebApplicationFactory in KebabCaseFormatterTests * fix: remaining functional tests * fix: minor changes PR review * fix: camelCase revert in comments * fix: camelCase revert in comments * fix: camelCase revert in comments * fix: camelCase revert in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default formatting to
camelCaseinstead ofkebab-case. This is the new recommendation by the json:api spec. Also see #555 for discussion.While redoing the CamelCaseControllerTests I did more research on the intended usage of
WebApplicationFactoryand worked out a clean way to define the Startup "overloads" in the test assemblies. SeeKebabCaseFormatterTestsandCreatingDataTests.