Changed TypeLocator to use ConcurrentDictionary for its cache #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made ResourceDescriptor immutable, to prevent changing the shared empty instance.
added 4 commits
March 10, 2020 15:14
I just realized that the strange interdependencies when running unit tests sequentially (causing tests to fail in AppVeyor, but not on TravisCI or locally) may actually be caused by the global cache instance.
…, though. Restored build script and re-added concurrent cache for running tests in parallel.
maurei
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this does not enable running multiple instances of JADNC with conflicting resource types in parallel, but it does allow for multiple tests to execute in parallel that all target the same JADNC application.
Also made ResourceDescriptor immutable, to prevent changing the shared empty instance.
Fixes #485.