Various fixes #731
Merged
Various fixes #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 14, 2020 17:11
…h an invalid content type. This change additionally allows extensions proposed at json-api/json-api#1437. Added test + fixes for running an endpoint that is not exposed through JsonApiDotNetCore (and we should not interfere)
Fixed: filter out duplicate selections Fixed: Top-level fields were missing when selecting only related fields Fixed: Select all fields when sparse fieldset contains a read-only property
…ndard (and block parameters)
…xpose them as DbSet properties on DbContext). Removed error on duplicates, to enable first scanning EF Core models, then add all resource definitons etc. from the assembly.
…of postponing them.
Inlined RelationshipAttribute.InternalRelationshipName Explicit interface implementation and property rename Inlined IsHasOne/IsHasMany on RelationshipAttribute
…ogether, but succeed individually)
…resource to set LastPasswordChange
Replaced usages of DateTime.Now with ISystemClock or constants Added IResourceFactory/DefaultResourceFactory to abstract creating resource instances
maurei
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that one test (sparse fieldsets with resource context injection) was added in disabled state, due to a bug in EF Core 3.1.