JADNC: Add required on post validator. #765
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
suggested changes
May 27, 2020
src/JsonApiDotNetCore/Models/CustomValidators/RequiredOnPostAttribute.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore/Models/CustomValidators/RequiredOnPostAttribute.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore/Models/CustomValidators/RequiredOnPostAttribute.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore/Models/CustomValidators/RequiredOnPostAttribute.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore/Models/CustomValidators/RequiredOnPostAttribute.cs
Outdated
Show resolved
Hide resolved
test/JsonApiDotNetCoreExampleTests/Acceptance/ResourceDefinitions/ResourceDefinitionTests.cs
Outdated
Show resolved
Hide resolved
test/JsonApiDotNetCoreExampleTests/Acceptance/ResourceDefinitions/ResourceDefinitionTests.cs
Show resolved
Hide resolved
test/UnitTests/Serialization/Server/RequestDeserializerTests.cs
Outdated
Show resolved
Hide resolved
src/JsonApiDotNetCore/Serialization/Server/RequestDeserializer.cs
Outdated
Show resolved
Hide resolved
|
Does this PR solve #472 (comment)? |
|
No, this does not resolve #472 (comment). I have converted back to draft because I want to give another approach a try. I did make the requested changes on this branch though. |
-formatting -add validation error to model state -allow empty strings -documentation
|
Decided to go another direction, found here: #781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
This feature is a custom validator which causes a resource property to be RequiredOnPost, and also validates that the resource property is not updated with a null value on Patch.