Routing does not respect custom pluralized resource name#805
Merged
Conversation
bart-degreed
changed the title
bart-degreed
changed the title
bart-degreed
suggested changes
Aug 26, 2020
bart-degreed
left a comment
bart-degreed
left a comment
Contributor
There was a problem hiding this comment.
See review feedback. In general, these types are mixing a lot of concerns and are deeply independent on each other, which makes it hard to track what is going on. But this was already the case, I'm not asking you to clean that up.
Contributor
|
I think this PR should address #807 as well. Docs are fully up-to-date and verified right now, so I don't see why it should be postponed. |
Contributor
|
Another question: can you confirm that #800 (comment) still holds? |
Member
Author
No: it this has not been the case for a long while now. The mapping between resources/routes/controllers is handled by |
Rephrasing
fix example fix: bump appveyor build fix: undo c# 8 syntax for using statements fix: attempt to fix win dispose bug fix: bump build fix: appveyor bump fix: appveyor build fix final
bart-degreed
force-pushed
the
fix/786
branch
from
18a3cf7 to
4262410
Compare
bart-degreed
suggested changes
Sep 3, 2020
bart-degreed
reviewed
Sep 4, 2020
bart-degreed
reviewed
Sep 4, 2020
Comment on lines
+50
to
+83
| public class Startup | ||
| { | ||
| private Action<MvcOptions> _postConfigureMvcOptions; | ||
|
|
||
| public void ConfigureServices(IServiceCollection services) | ||
| { | ||
| ... | ||
|
|
||
| var builder = services.AddMvcCore(); | ||
| services.AddJsonApi<AppDbContext>( ... , mvcBuilder: builder); | ||
| mvcCoreBuilder.AddMvcOptions(x => | ||
| { | ||
| // execute the mvc configuration callback after the JsonApiDotNetCore callback as been executed. | ||
| _postConfigureMvcOptions?.Invoke(x); | ||
| }); | ||
|
|
||
| ... | ||
| } | ||
|
|
||
| public void Configure(IApplicationBuilder app, IWebHostEnvironment environment) | ||
| { | ||
|
|
||
| ... | ||
|
|
||
| // Using a callback, we can defer to later (when service collection has become available). | ||
| _postConfigureMvcOptions = mvcOptions => | ||
| { | ||
| mvcOptions.Filters.Clear(); | ||
| mvcOptions.Filters.Insert(0, app.ApplicationServices.GetService<CustomFilter>()); | ||
| }; | ||
|
|
||
| ... | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
You put the call to app.UseJsonApi() in the wrong place. And didn't fix the white space.
bart-degreed
suggested changes
Sep 4, 2020
bart-degreed
left a comment
bart-degreed
left a comment
Contributor
There was a problem hiding this comment.
See comments. I've resolved the fixed items. What's still open is not yet addressed,
bart-degreed
reviewed
Sep 9, 2020
bart-degreed
reviewed
Sep 9, 2020
bart-degreed
reviewed
Sep 9, 2020
bart-degreed
approved these changes
Sep 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #786
Closes #807
JsonApiRoutingConventionnow depends onIResourceGraphrather thanResourceNameFormatter. As a result:publicResourceNameargument inAddResource<T>( ... )is now respected, see my comment in PluralizedTypeName option when adding resource doesn't work for routing #786.JsonApiRoutingConvention, specifically)