Various code cleanups in preparation of auto-formatting the codebase#960

Merged

bart-degreed merged 61 commits into

coding-guidelines-4

Mar 3, 2021

Commits on Feb 15, 2021

Replaced null checks with argument guard
Bart Koelman
committed
Added curlies on single-statement branches and loops
Bart Koelman
committed
Normalize blank lines around SaveChangesAsync in tests
Bart Koelman
committed
use const
Bart Koelman
committed
Move types into matching files
Bart Koelman
committed
Adapt namespaces to match with directory structure
Bart Koelman
committed
Fixed inconsistencies in naming conventions
Bart Koelman
committed
Remove redundant parenthesis
Bart Koelman
committed
Fixed culture-specific string comparisons
Bart Koelman
committed

Commits on Feb 17, 2021

Use newer syntax for dictionary initializers
Bart Koelman
committed
Various additional cleanups
Bart Koelman
committed
Manual code cleanups in preparation for reformat
Bart Koelman
committed
Extract variable on errors in tests to reduce assertion line length
Bart Koelman
committed
Hide decimal precision from tests
Bart Koelman
committed
Rewrite ResponseStatusCode tests using Theory
Bart Koelman
committed
Fixed naming inconsistencies in tests
Bart Koelman
committed
Replace FindAsync usage for consistency with other tests
Bart Koelman
committed
Added formatter directives on fakers
Bart Koelman
committed
Added formatter directives on DbContext types
Bart Koelman
committed

Commits on Feb 18, 2021

Added FirstWithIdAsync / FirstWithIdOrDefaultAsync to reduce line length on database queries in tests
Bart Koelman
committed
Added formatting directives on long database queries in tests
Bart Koelman
committed
Reduced line length for links assertions
Bart Koelman
committed
Variable naming consistency
Bart Koelman
committed
Break up long strings to steer formatter
Bart Koelman
committed

Commits on Feb 19, 2021

Extract constant
Bart Koelman
committed

Commits on Feb 22, 2021

cleanup method
Bart Koelman
committed
Fixed naming conventions
Bart Koelman
committed

Commits on Feb 25, 2021

Additional cleanup based on suggestions from https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/
Bart Koelman
committed
Use helpers to prevent multiple line breaks in array and list initializers
Bart Koelman
committed
Corrected link rendering for hosting inside an IIS application vdir (#955)
Bart Koelman
committed
Update version from 4.0.3 to 4.0.4
Bart Koelman
committed
Marked types/members sealed/internal where non-breaking
Bart Koelman
committed
Removed redundancies in code
Bart Koelman
committed
remove unused tuple elements
Bart Koelman
committed
Fixed spelling in comments
Bart Koelman
committed
Added formatter directive to ErrorDocumentTests to prevent array chop
Bart Koelman
committed
Added [UsedImplicitly] on DbContext classes to suppress suggestions like 'member can be private, set accessor is never used'etc.
Bart Koelman
committed
Added [UsedImplicitly] on resource services, repositories, definitions and startups
Bart Koelman
committed
Added [UsedImplicitly] on models
Bart Koelman
committed
Use discard in empty property setters
Bart Koelman
committed
Added missing setter
Bart Koelman
committed
Addressed possible NullReferenceException warnings
Bart Koelman
committed
Marked assertion methods as such, to suppress warning 'parameter is only used for precondition checks'
Bart Koelman
committed
Addressed possible multiple enumeration warnings
Bart Koelman
committed
Suppressed warnings on non-readonly member access in GetHashCode, because these are assigned once at application startup by the resource graph builder and then are considered immutable.
Bart Koelman
committed
extra: UsedImplicitly on models
Bart Koelman
committed
Added [PublicAPI] on exposed types to suppress warnings like 'type/member can be made internal', 'type has no inheritors and can be marked sealed', 'member is never written to' etc.
Bart Koelman
committed
Cleanup Startups
Bart Koelman
committed
BenchmarkDotNet runners cannot be sealed
Bart Koelman
committed
Suppress cases of unused TResource type parameter, because we register an open generic for them to enable different implementations per resource type.
Bart Koelman
committed
Additional cleanup and annotations based on warnings and suggestions
Bart Koelman
committed

Commits on Feb 27, 2021

AV1755: Async method name should end with [Task]Async
Bart Koelman
committed
AV1739: Use underscores for unused lambda parameters
Bart Koelman
committed
AV1568: Parameter value is overwritten in method body
Bart Koelman
committed
AV1535: Block scope in case clauses
Bart Koelman
committed
AV1522: Multiple assignments in single statement
Bart Koelman
committed

Commits on Mar 2, 2021

AV1532: Avoid nested loops
Bart Koelman
committed
AV1010: Member hides inherited member
Bart Koelman
committed
AV1130: Use collection interface as return type
Bart Koelman
committed

Commits on Mar 3, 2021