Make InputFormatters and OutputFormatters implement IApiRequestFormatMetadataProvider #967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bart-degreed
suggested changes
Mar 12, 2021
|
|
||
| private bool IsAtomicOperationsType(Type objectType) | ||
| { | ||
| return objectType.GetInterface(nameof(IEnumerable)) != null && objectType.GetGenericArguments().First() == _operationContainerType; |
There was a problem hiding this comment.
I wanted to try why such complex logic is needed, instead of the obvious typeof(IList<OperationContainer>), but there are no tests. Add some tests first, please.
| @@ -5,8 +5,8 @@ | |||
|
|
|||
| namespace JsonApiDotNetCore.Middleware | |||
| { | |||
| /// <inheritdoc /> | |||
| public sealed class JsonApiInputFormatter : IJsonApiInputFormatter | |||
| /// <inheritdoc cref="JsonApiDotNetCore.Middleware.IJsonApiInputFormatter" /> | |||
There was a problem hiding this comment.
I assume the cref is to disambiguate between the docs on JsonApiFormatter and IJsonApiInputFormatter. We haven't used this before, but perhaps we should start doing that. Does this work correctly in:
- the generated documentation website?
- IntelliSense in IDE when consuming our NuGet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonApiInputFormatterimplementsIApiRequestFormatMetadataProvider.JsonApiOutputFormatterimplementsIApiResponseFormatMetadataProvider.