Skip to content

Repro for issue 988 #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Repro for issue 988 #990

wants to merge 3 commits into from

Conversation

bart-degreed
Copy link
Contributor

Bug repro for #988.

@bart-degreed bart-degreed marked this pull request as draft May 6, 2021 11:25
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #990 (0753695) into master (d033166) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
+ Coverage   91.26%   91.30%   +0.04%     
==========================================
  Files         281      281              
  Lines        7429     7430       +1     
==========================================
+ Hits         6780     6784       +4     
+ Misses        649      646       -3     
Impacted Files Coverage Δ
.../Internal/QueryableBuilding/SelectClauseBuilder.cs 92.30% <100.00%> (-1.87%) ⬇️
...ore/Repositories/MemoryLeakDetectionBugRewriter.cs 0.00% <0.00%> (-100.00%) ⬇️
...Core/Repositories/EntityFrameworkCoreRepository.cs 98.58% <0.00%> (-0.95%) ⬇️
src/JsonApiDotNetCore/Resources/ResourceFactory.cs 88.46% <0.00%> (+19.23%) ⬆️
src/JsonApiDotNetCore/CollectionConverter.cs 97.43% <0.00%> (+28.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d033166...0753695. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant