Skip to content

use json.Marshaler then trim the last '\n' in reflect_marshaler #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

teou
Copy link
Contributor

@teou teou commented Aug 14, 2019

use json.Marshaler again :-) then trim the last '\n' in reflect_marshaler.
fix #397

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #398 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   81.81%   81.71%   -0.11%     
==========================================
  Files          41       41              
  Lines        5022     5026       +4     
==========================================
- Hits         4109     4107       -2     
- Misses        792      798       +6     
  Partials      121      121
Impacted Files Coverage Δ
reflect_marshaler.go 81.25% <100%> (+0.6%) ⬆️
reflect_struct_decoder.go 48.32% <0%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27518f6...9764548. Read the comment docs.

@taowen taowen merged commit 819acad into json-iterator:master Sep 23, 2019
zhenzou pushed a commit to zhenzou/jsoniter that referenced this pull request Feb 2, 2022
use json.Marshaler then trim the last '\n' in reflect_marshaler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EscapeHTML=false doesn't work
2 participants