Skip to content

Add text clarifying what an "unconnected node" is.#479

Merged
gkellogg merged 2 commits into
masterfrom
issue-418
Apr 10, 2017
Merged

Add text clarifying what an "unconnected node" is.#479
gkellogg merged 2 commits into
masterfrom
issue-418

Conversation

@gkellogg

@gkellogg gkellogg commented Apr 9, 2017

Copy link
Copy Markdown
Contributor

Fixes #418.

@gkellogg gkellogg added this to the JSON-LD 1.1 milestone Apr 9, 2017
@gkellogg gkellogg requested a review from dlongley April 9, 2017 22:59
@gkellogg gkellogg self-assigned this Apr 9, 2017
@gkellogg

gkellogg commented Apr 9, 2017

Copy link
Copy Markdown
Contributor Author

@dlongley If this resolution is satisfactory, we can just merge it.

Comment thread spec/latest/json-ld/index.html Outdated
-->
</pre>
<div class="note">
This effectivly just bans node objects containing only an <code>@id</code>.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "effectivly" => "effectively"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see someone (who does not read the rest of the spec, which is common) getting confused by this wording and also thinking this is illegal:

{
  "foo:bar": {
    "@id": "http://example.org/1"
  }
}

As that nested node contains only an @id. Perhaps a slight tweak:

This effectively prohibits unnested, empty node objects and unnested node objects that contain only an <code>@id</code>.

@gkellogg gkellogg merged commit 014f2d4 into master Apr 10, 2017
@gkellogg gkellogg deleted the issue-418 branch April 10, 2017 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants