Conversation
Contributor
Author
|
@dlongley If this resolution is satisfactory, we can just merge it. |
dlongley
requested changes
Apr 10, 2017
| --> | ||
| </pre> | ||
| <div class="note"> | ||
| This effectivly just bans node objects containing only an <code>@id</code>. |
Member
There was a problem hiding this comment.
typo: "effectivly" => "effectively"
Member
There was a problem hiding this comment.
I can see someone (who does not read the rest of the spec, which is common) getting confused by this wording and also thinking this is illegal:
{
"foo:bar": {
"@id": "http://example.org/1"
}
}As that nested node contains only an @id. Perhaps a slight tweak:
This effectively prohibits unnested, empty node objects and unnested node objects that contain only an <code>@id</code>.
…about empty node objects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418.