Skip to content

Paper suggests that the test suite is lacking #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Relequestual opened this issue May 3, 2016 · 9 comments
Closed

Paper suggests that the test suite is lacking #115

Relequestual opened this issue May 3, 2016 · 9 comments

Comments

@Relequestual
Copy link
Member

Relequestual commented May 3, 2016

http://www2016.net/proceedings/proceedings/p263.pdf

Specifcially section 2...
"Table 1 shows the outcome of this process, It is impor-
tant to mention that all validators successfully validate the
JSON Schema test-suite [4]. As we can see, no two valida-
tors behave the same on all inputs, which is clearly not the
desired behaviour. This illustrates the need for a formal
de nition of JSON Schema which will either disallow am-
biguous schemas, or formally specify how these should be
evaluated."

I'm not sure on their methods, and I'm not especially up for downloading random code from academic URLs.
I've contacted them regarding something else. If I get a reply, I'll push them to publish the code in a repo or as a gist, and see if they deliver. It's a shame they didn't feel the need to put it on github.

@Relequestual
Copy link
Member Author

They replied! I'll keep this issue posted.

@Julian
Copy link
Member

Julian commented May 3, 2016

Please do, thanks! If they can offer any specifics would be great to fill
in some gaps.
On May 3, 2016 17:38, "Ben Hutton" [email protected] wrote:

They replied! I'll keep this issue posted.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#115 (comment)

@seagreen
Copy link

seagreen commented Jul 6, 2016

Any luck? That part of the paper was a hilarious tease -- it gave us just enough info to know they've got something very useful for the test suite, but not enough to know what it is.

@Relequestual
Copy link
Member Author

@seagreen Nope. Had no further update. I'll chase them via email to ask if they ever looked into providing further info. =]

@iainbeeston
Copy link
Contributor

I've taken a look at the paper and the code released with it, and reproduced the test cases in #128

@iainbeeston
Copy link
Contributor

FYI they explained the tests they used in section 2, with the full code available online in the appendices under "available validator tests code". In fact the paper describes 4 tests but the source code actually has a 5th test, which I've also included.

@Relequestual
Copy link
Member Author

@iainbeeston It's great you've been able to find time to review the paper properly and the associated code. Super thankyou and really appreciated. There's still a lot I don't really understand about what they were getting at with regards JSON Schema needing a formal syntax, but that might be more academic than practical (or I may miss the point completely). I'm very much in favour of having practical examples when anyone calls out a probelm.

@Julian
Copy link
Member

Julian commented Nov 20, 2016

Gonna close this in favor of #128 which @iainbeeston was so kind to submit.

@Julian Julian closed this as completed Nov 20, 2016
@Relequestual
Copy link
Member Author

I'm happy with this issue being closed in this way, with the new issue superseeding this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants