When $ref is present other keywords should be ignored #142
Conversation
|
I was sure there was a test covering this already but it appears there isn't... thanks for submitting. Leaving some comments. |
| @@ -141,6 +141,32 @@ | |||
| ] | |||
| }, | |||
| { | |||
| "description": "ref, containing other keywords", | |||
There was a problem hiding this comment.
Would be a bit clearer I think to say something like "ref overrides any sibling keywords" which is the behavior, rather than just describing the situation without explicitly pointing that out.
| "properties": { | ||
| "foo": { | ||
| "$ref": "#/definitions/reffed", | ||
| "type": "integer" |
There was a problem hiding this comment.
Think it also might be clearer to pick an example that isn't just conflicting keywords. E.g., using type array behind a $ref but having a minLength will ignore the minLength sibling.
There was a problem hiding this comment.
But that's true anyway, isn't it?
"properties": {
"foo": {
"type": "array",
"minLength": 10,
}
}validates "foo": [] and "foo": [1, "a", {}] but not "foo": "short" or "foo": "thisiswaytoolong"
because "minLength" can only fail validation against string instances. It has no effect on other types.
| "valid": true | ||
| }, | ||
| { | ||
| "description": "remote ref valid", |
pipobscure
force-pushed
the
refOnly
branch
2 times, most recently
from
7ed7f50 to
e31fce9
Compare
|
Better? Is this what you meant? |
|
Yes, nice work! Merging. |
See answer by @Julian on #129