Add check for non-zero padded days and months #425
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenetheridge
requested changes
Aug 13, 2020
There was a problem hiding this comment.
- all the tests in tests/draft*/format.json must
passhavevalid: true, as the 'format' keyword is just an annotation by default and does not validate. Validation tests should be in optional/format/*.json. - could you update the other drafts' tests too please?
Feel free to squash your commits and force-push.
|
I'm going to close this and re-open another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in IETF RFC 3559, section 5.6, dates should follow the format
YYYY-MM-DD, so days or months that are non-zero padded should be invalid.