Add tests for refs into schemas with file:// URI $id
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdesrosiers
requested changes
Apr 5, 2023
tests/draft2020-12/ref.json
Outdated
| { | ||
| "description": "$id with file URI still resolves pointers - *nix", | ||
| "schema": { | ||
| "$id": "file://folder/file.json", |
There was a problem hiding this comment.
The "path" part needs to start with a slash. Otherwise "folder" would be interpreted as a domain part rather than part of the path. It's technically a valid URI, it just doesn't mean what was intended.
Suggested change
| "$id": "file://folder/file.json", | |
| "$id": "file:///folder/file.json", |
There was a problem hiding this comment.
I always wondered what that third slash was for. Blank domain.
jdesrosiers
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #665
These all pass on my implementation (after the json-everything/json-everything#427 fix).