Add test for sibling $ref and $id in nested schema to 2019-09 and 2020-12 suites #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I was having trouble figuring out what exactly was in these that wasn't already covered. The distinction from the existing tests is siblings Tests look correct to me, passes in my implementation. |
jdesrosiers
requested changes
Oct 30, 2025
Member
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Looks good! Please add this test to the v1 folder as well and this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #787.
Changes confirmed against the NetworkNT JSON Schema Validator, which is where the ambiguity was first noticed. I confirmed that the prior version of the NetworkNT validator fails the new tests as expected (it throws an exception while trying to load the non-existent
https://example.com/draftX-Y/ref-and-id3/bar.json), and that the latest/fixed version passes the new tests.@jdesrosiers might be a suitable reviewer.