stop using the term "draft" to mean "version", and fix the remaining mentions of draft-next (now v1) #791
Conversation
…mentions of draft-next (now v1)
jdesrosiers
left a comment
jdesrosiers
left a comment
There was a problem hiding this comment.
Thanks! I knew I was probably missing something.
I made one comment inline. It's not necessarily something that needs to be changed in this PR, but it was something I noticed when reviewing.
| * For 2019-09 and later published drafts, implementations that are able to detect the draft of each schema via `$schema` SHOULD be configured to do so | ||
| * For draft-07 and earlier, draft-next, and implementations unable to detect via `$schema`, implementations MUST be configured to expect the draft matching the test directory name | ||
| * For 2019-09 and later published versions, implementations that are able to detect the version of each schema via `$schema` SHOULD be configured to do so | ||
| * For draft-07 and earlier, v1 (not yet released), and implementations unable to detect via `$schema`, implementations MUST be configured to expect the version matching the test directory name |
There was a problem hiding this comment.
I'm not sure why draft-next was included in this bullet. That doesn't seem correct to me and I don't think it's correct for v1 either.
| * For draft-07 and earlier, v1 (not yet released), and implementations unable to detect via `$schema`, implementations MUST be configured to expect the version matching the test directory name | |
| * For draft-07 and earlier, and implementations unable to detect via `$schema`, implementations MUST be configured to expect the version matching the test directory name |
There was a problem hiding this comment.
I'm going to leave this for now, as it's still not clear to me (nor is it in the latest version of the spec documents in json-schema-spec main branch) whether the name of the draft is actually intended to be "v1" or "v1/<year>" and how $schema keywords would refer to it.
As far as the test suite is concerned, as long as everything consistently refers to "v1" then test harnesses or implementations can just skip this directory entirely for now, as they would have done for "draft-next".
I found this while updating my test harness with the most recent commits.