added some verbiage to the vocabularies example for clarity #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relequestual
requested changes
Jul 1, 2019
|
"Request changes" is more for me =] |
Make it clearer that if an unkown vocab has `false` as its value, it can be ignored, and any keywords it would add should be ignored. Redefine behaviour of `false` value on `$vocabularies` object to SHOULD rather than MAY, which I feel is likely better in line with intent and schema authors expectations, given the `true/false` value represents if the vocab is always required for procesing (or not).
|
Looks like I'm using an older version of xml2rfc. |
|
This looks good to me. |
|
Seems like @handrews went his own way. Probably don't need this in the spec anymore. Might still be useful for the site, though. |
|
@gregsdennis I had actually not intended to invalidate this and had meant to come back and look at reconciling, but perhaps it's better for me to just finish the PR I have up and we can see what's still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the text in the example isn't proper "spec-ese" but in the context of an example, I think that's fine.