Skip to content

Make a real, appropriately short, Overview section #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

handrews
Copy link
Contributor

I think this dramatically improves the flow of the document. There is almost certainly more to do, but just having a concise overview and going from brief descriptions to detailed descriptions is a vast improvement.

The "Keyword Behavior" section is moved, completely unchanged,
to immediately after the "General Considerations", where
it makes quite a bit more sense. The "General Considerations"
section gives a brief description of the keyword types,
which makes a lot more sense before the detailed description
rather than after it.

The old "Schema Vocabularies" section has mostly been deleted,
as it took up a lot of space without adding much. Given that
the validation spec now contains four or five vocabularies,
enumerating all of them plus hyper-schema (which is highly
unlikely to reach RFC at the same time as core) seemed
like an overlaod of non-essential information.

The introductory paragraph is still useful, so it has been
spliced into the appropriate location in the
"Meta-Schemas and Vocabularies" section, and the reference
anchor has been given to that section as well. The contents
of that paragraph are also completely unchanged.

The "Keyword Behavior" section is moved, completely unchanged,
to immediately after the "General Considerations", where
it makes quite a bit more sense.  The "General Considerations"
section gives a brief description of the keyword types,
which makes a lot more sense before the detailed description
rather than after it.

The old "Schema Vocabularies" section has mostly been deleted,
as it took up a lot of space without adding much.  Given that
the validation spec now contains four or five vocabularies,
enumerating all of them plus hyper-schema (which is highly
unlikely to reach RFC at the same time as core) seemed
like an overlaod of non-essential information.

The introductory paragraph is still useful, so it has been
spliced into the appropriate location in the
"Meta-Schemas and Vocabularies" section, and the reference
anchor has been given to that section as well.  The contents
of that paragraph are also completely unchanged.
Copy link
Collaborator

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change, but not essential.
This is MUCH BETTER =D - Flow is clearer.

consists of a list of keywords, together with their syntax and semantics.
</t>
<t>
JSON Schema can be extended either by adding vocabularies, or less formally
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by adding vocabularies where?
..."when defining a new meta-schema,"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your point here, although I think I have a better solution. "adding" makes it sound like there is some specific place to which to add the thing. I don't want to get into meta-schemas in this overview, so instead of "adding vocabularies" let's go with "defining new vocabularies" or "defining additional vocabularies". And likewise "defining new keywords" or "defining additional keywords" instead of "adding keywords."

BTW when I do the next clarifications I'll make it clear that the thing you do in a meta-schema is declare vocabularies, while defining vocabularies is (currently) done in specification text.

Make it more clear that extending involves defining more
vocabularies and/or keywords, not adding existing
vocabularies/keywords from some place to some other place.
@Relequestual Relequestual merged commit 9aa3537 into json-schema-org:master Jul 11, 2019
@handrews handrews deleted the rework branch July 11, 2019 16:07
@gregsdennis gregsdennis added clarification Items that need to be clarified in the specification and removed Type: Maintenance labels Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Items that need to be clarified in the specification core Priority: High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants