Skip to content

Parveen/fixed date at draft 4 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

praveen-rikhari
Copy link
Contributor

GitHub Issue: #123

Summary:

  • fixed date at draft 4 on file pages/specification-links.md

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

Yes/No
No

@praveen-rikhari
Copy link
Contributor Author

@benjagm Please review.If any other modifications required please let me know.

benjagm
benjagm previously approved these changes Feb 28, 2024
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Approved from my side!

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

Why a new PR @praveen-rikhari ? The PR is #386 right?

@praveen-rikhari
Copy link
Contributor Author

@benjagm thanks for approving. I thought the fixed version should be on a separate PR.

@benjagm
Copy link
Collaborator

benjagm commented Feb 28, 2024

Let's continue all the changes in #386 . My apologies if there was a misunderstanding.

@praveen-rikhari
Copy link
Contributor Author

tracking this in #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants