feat: added resource section with article and books routes working #395
Conversation
.gitmodules
Outdated
| @@ -40,3 +40,6 @@ | |||
| [submodule "_includes/dot-github"] | |||
| path = _includes/dot-github | |||
| url = https://github.com/json-schema-org/.github.git | |||
| [submodule "path/to/submodule"] | |||
There was a problem hiding this comment.
We should not import this data as submodule. We like to avoid this type of dependency from projects outside our org. We'll do our own version of the data file in our data folder.
components/Sidebar.tsx
Outdated
| className={classnames( 'ml-6', { 'hidden': !active.getResources })} | ||
| id='resources' | ||
| > | ||
| <DocLink uri='/resources/books' label='Books' /> |
There was a problem hiding this comment.
These are static links. I'd like to avoid this. Instead I'd like you to go through the data and extract the resource categories available there to build dynamically these links.
| @@ -0,0 +1,80 @@ | |||
| import React, { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
I expect one single generic resources page that accepts the resource type as parameters os it will work for all cases.
pages/resources/books/index.page.tsx
Outdated
| @@ -0,0 +1,76 @@ | |||
| import React, { useEffect, useState } from "react"; | |||
There was a problem hiding this comment.
I expect one single generic resources page that accepts the resource type as parameters os it will work for all cases.
Akshaybagai52
force-pushed
the
feature/resource-section
branch
from
16e9a28 to
80cf4c1
Compare
GitHub Issue: #282
Summary:
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
Yes/No
[JUSTIFICATION]