Skip to content

Fix: Pin friendsofphp/php-cs-fixer to minor version #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2018

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Oct 17, 2018

❗️ Blocks #491.

This PR

  • pins friendsofphp/php-cs-fixer to a compatible minor version
  • removes unknown fixers

Follows #491 (comment).

Copy link
Collaborator

@bighappyface bighappyface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for 8273113
+1 for 276b51c

@erayd any concerns here?

@localheinz I would prefer to accept this PR before #491.

@localheinz
Copy link
Contributor Author

@bighappyface

Sounds good!

@bighappyface bighappyface merged commit 0ccb470 into jsonrainbow:master Oct 19, 2018
@localheinz localheinz deleted the fix/php-cs-fixer branch October 19, 2018 15:45
@localheinz
Copy link
Contributor Author

Thank you, @bighappyface!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants