Improve support for empty and non-ASCII-alphabetic properties, enum values, and definitions #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16 as well as related issues.
At its base, this PR does two things:
""
,"1foo"
," "
, or "\uFDFD".The name generating logic now has the following invariants:
"default"
and"name"
, producingdefault_name
,defaultName
, etc. depending on the target's chosen casing.Test cases that exercise these cases are added to all targets. However, Java+Jackson does not support empty property names or enum values, and Go does not support non-ASCII-alphanumeric property names. For this reason, each target's test cases are handled separately. All targets are required to support non-ASCII-alphanumeric definition names, however.