no-unused-prop-types throwing error for destructured props

[woodenconsulting]

Sample Code

function myStatelessComponent(props) {
  const { test: { foo, bar } } = props;
  return (
    <div>
      {foo} {bar}
    </div>
  );
}

myStatelessComponent.propTypes = {
  test: PropTypes.shape({
    foo: PropTypes.string.isRequired,
    bar: PropTypes.string.isRequired
  }).isRequired
};

Issue

The linter erroneously throws on the test prop since only its descendants are used:
'test' PropType is defined but prop is never used react/no-unused-prop-types.

The issue first appeared with the 7.15.0 release published about 11 hours ago from the time of this writing. It's likely due to this commit.

Expected

The linter should not throw

[ljharb]

cc @golopot

[golopot]

I cannot reproduce this. I added the test case in my fork branch and CI is passing. https://github.com/golopot/eslint-plugin-react/tree/eeee
https://travis-ci.org/golopot/eslint-plugin-react/builds/592117332

I have tried espree, babel-eslint, @typescript-eslint/parser, env: {mocha: true}, and declaring a local variable named test.

[ljharb]

a PR with the test case would be appreciated.

@woodenconsulting can you provide any more info that would be helpful?

[woodenconsulting]

@golopot @ljharb I created a repo which reproduces the issue: https://github.com/woodenconsulting/epr-2424

Additional Notes

• Unlike the code I first provided, the issue is only prevalent when I import the shape
• The issue also goes away when I remove the eslint-config-airbnb plugin that we're using

I haven't had a chance to dig any further; however, for additional context this error is happening across several private repos where pinning to the prior version of eslint-plugin-react solves the issue (for now).

[ljharb]

aha, that first bullet point seems like the trick.

[woodenconsulting]

@golopot Your fix does indeed resolve the issue, thanks for the quick turn around! 💯

[w33ble]

Can confirm. Thanks for the fix and the notification. 🥇