Skip to content

docs(prefer-es6-class): add missing prefix #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2017
Merged

docs(prefer-es6-class): add missing prefix #1071

merged 2 commits into from
May 16, 2017

Conversation

adnasa
Copy link
Contributor

@adnasa adnasa commented Feb 14, 2017

figured...

@ljharb
Copy link
Member

ljharb commented Feb 14, 2017

All of the rules docs omit the react/ prefix, by convention.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017

@ljharb all of them?

at least from my side, this caused some confusion when setting up the config initially.

@adnasa adnasa changed the title docs(prefer-es6-class): correct typo in doc docs(prefer-es6-class): add missing prefix Feb 14, 2017
lencioni
lencioni approved these changes Feb 14, 2017
View reviewed changes
Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as an improvement. It would be nice to make them all consistent though.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 14, 2017 •
edited
Loading

@lencioni yeah I agree on consistency 😉 let's do that (on a separate PR)!

@ljharb
Copy link
Member

ljharb commented Feb 14, 2017

As long as they're all the same, I'm happy :-) it'd be nice to update this PR to do all of them, but a separate one is fine too.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 15, 2017

you're right. we can do it in this PR

@adnasa
Copy link
Contributor Author

adnasa commented Feb 15, 2017

@ljharb @lencioni done

lencioni
lencioni approved these changes Feb 15, 2017
View reviewed changes
Copy link
Collaborator

@lencioni lencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/rules/self-closing-comp.md
@@ -1,4 +1,4 @@
# Prevent extra closing tags for components without children (self-closing-comp)
# Prevent extra closing tags for components without children (react/self-closing-comp)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may have missed some other lines like this one (e.g. see require-optimization). It might be worth making another pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, I wasn't supposed to add the prefix on the title. shall we proceed with this? 😛

@lencioni lencioni mentioned this pull request Feb 15, 2017
Merged
@ljharb ljharb mentioned this pull request Feb 18, 2017
Closed
@ljharb
Copy link
Member

ljharb commented Feb 18, 2017 •
edited
Loading

@adnasa it looks like this needs a rebase, and it seems like #1078 has found a file that your PR doesn't update.

@adnasa
Copy link
Contributor Author

adnasa commented Feb 18, 2017

@ljharb an update is coming up later this weekend 😉

@adnasa
Copy link
Contributor Author

adnasa commented Feb 19, 2017 •
edited
Loading

@ljharb corrected the merge conflict 6334d63

@ljharb
Copy link
Member

ljharb commented Feb 19, 2017

@adnasa would you mind rebasing so as to remove the merge commit?

@yannickcr yannickcr mentioned this pull request Mar 22, 2017
Merged
@adnasa adnasa force-pushed the typo-prefer-es6-class branch from 9622ac6 to 5a02508 Compare May 16, 2017 05:07
@adnasa
Copy link
Contributor Author

adnasa commented May 16, 2017

@ljharb Hey,
Sorry for being late on this! 😋
I finally did it, haha

@ljharb ljharb merged commit ecc327a into jsx-eslint:master May 16, 2017
@adnasa adnasa deleted the typo-prefer-es6-class branch May 16, 2017 07:56
@renovate-bot renovate-bot mentioned this pull request Jun 15, 2017
Merged
@renovate renovate bot mentioned this pull request Feb 2, 2018
Open
1 task
This was referenced Sep 22, 2018
Closed
Closed
Open
Open
@gabrc52 gabrc52 mentioned this pull request Sep 3, 2024
Merged
This was referenced Sep 9, 2024
Merged
Merged
@renovate renovate bot mentioned this pull request Nov 21, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@lencioni lencioni lencioni approved these changes

Assignees
No one assigned
Labels
documentation
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adnasa @ljharb @lencioni