[eslint] enable eslint-plugin-eslint-plugin

.eslintrc

@@ -1,6 +1,7 @@
 {
     "root": true,
-    "extends": "airbnb-base",
+    "extends": ["airbnb-base", "plugin:eslint-plugin/recommended"],
+    "plugins": ["eslint-plugin"],
     "env": {
        "es6": true,
        "node": true

lib/rules/jsx-child-element-spacing.js

@@ -45,7 +45,7 @@ module.exports = {
       recommended: false,
       url: docsUrl('jsx-child-element-spacing')
     },
-    fixable: false,
+    fixable: null,
     schema: [
       {
         type: 'object',

package.json

@@ -28,6 +28,7 @@
   "dependencies": {
     "array-includes": "^3.0.3",
     "doctrine": "^2.1.0",
+    "eslint-plugin-eslint-plugin": "^2.1.0",
     "has": "^1.0.3",
     "jsx-ast-utils": "^2.2.1",
     "object.entries": "^1.1.0",

tests/lib/rules/default-props-match-prop-types.js

@@ -268,7 +268,8 @@ ruleTester.run('default-props-match-prop-types', rule, {
         'Greeting.defaultProps = {',
         '  foo: "foo"',
         '};'
-      ].join('\n')
+      ].join('\n'),
+      parser: parsers.BABEL_ESLINT
     },
     {
       code: [
@@ -530,7 +531,8 @@ ruleTester.run('default-props-match-prop-types', rule, {
         '  ...defaults,',
         '  bar: "bar"',
         '};'
-      ].join('\n')
+      ].join('\n'),
+      parser: parsers.BABEL_ESLINT
     },
 
     //
@@ -845,6 +847,26 @@ ruleTester.run('default-props-match-prop-types', rule, {
         column: 3
       }]
     },
+    {
+      code: [
+        'function MyStatelessComponent({ foo, bar }) {',
+        '  return <div>{foo}{bar}</div>;',
+        '}',
+        'MyStatelessComponent.propTypes = {',
+        '  foo: React.PropTypes.string,',
+        '  bar: React.PropTypes.string.isRequired',
+        '};',
+        'MyStatelessComponent.defaultProps = {',
+        '  baz: "baz"',
+        '};'
+      ].join('\n'),
+      errors: [{
+        message: 'defaultProp "baz" has no corresponding propTypes declaration.',
+        line: 9,
+        column: 3
+      }],
+      parser: parsers.BABEL_ESLINT
+    },
     {
       code: [
         'function MyStatelessComponent({ foo, bar }) {',
@@ -1348,25 +1370,6 @@ ruleTester.run('default-props-match-prop-types', rule, {
         column: 5
       }]
     },
-    {
-      code: [
-        'function MyStatelessComponent({ foo, bar }) {',
-        '  return <div>{foo}{bar}</div>;',
-        '}',
-        'MyStatelessComponent.propTypes = {',
-        '  foo: React.PropTypes.string,',
-        '  bar: React.PropTypes.string.isRequired',
-        '};',
-        'MyStatelessComponent.defaultProps = {',
-        '  baz: "baz"',
-        '};'
-      ].join('\n'),
-      errors: [{
-        message: 'defaultProp "baz" has no corresponding propTypes declaration.',
-        line: 9,
-        column: 3
-      }]
-    },
     {
       code: [
         'class Greeting extends React.Component {',

tests/lib/rules/destructuring-assignment.js

@@ -21,15 +21,6 @@ const parserOptions = {
 const ruleTester = new RuleTester({parserOptions});
 ruleTester.run('destructuring-assignment', rule, {
   valid: [{
-    code: `const Foo = class extends React.PureComponent {
-      render() {
-        const { foo } = this.props;
-        return <div>{foo}</div>;
-      }
-    };`,
-    options: ['always'],
-    parser: parsers.BABEL_ESLINT
-  }, {
     code: `const MyComponent = ({ id, className }) => (
       <div id={id} className={className} />
     );`
@@ -102,15 +93,16 @@ ruleTester.run('destructuring-assignment', rule, {
         return <div>{foo}</div>;
       }
     };`,
-    options: ['always'],
-    parser: parsers.BABEL_ESLINT
+    options: ['always']
   }, {
     code: `const Foo = class extends React.PureComponent {
       render() {
         const { foo } = this.props;
         return <div>{foo}</div>;
       }
-    };`
+    };`,
+    options: ['always'],
+    parser: parsers.BABEL_ESLINT
   }, {
     code: `const Foo = class extends React.PureComponent {
       render() {
@@ -119,7 +111,7 @@ ruleTester.run('destructuring-assignment', rule, {
       }
     };`,
     options: ['always'],
-    parser: parsers.BABEL_ESLINT
+    parser: parsers.TYPESCRIPT_ESLINT
   }, {
     code: `const MyComponent = (props) => {
       const { h, i } = hi;

tests/lib/rules/jsx-curly-brace-presence.js

@@ -508,7 +508,8 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
       code: `<MyComponent prop="foo 'bar'">foo</MyComponent>`,
       output: `<MyComponent prop={"foo 'bar'"}>foo</MyComponent>`,
       options: [{props: 'always'}],
-      errors: [{message: missingCurlyMessage}]
+      errors: [{message: missingCurlyMessage}],
+      parser: parsers.BABEL_ESLINT
     },
     {
       code: '<MyComponent>foo bar </MyComponent>',

tests/lib/rules/jsx-curly-spacing.js

@@ -405,7 +405,8 @@ ruleTester.run('jsx-curly-spacing', rule, {
       '...bar',
       '} />;'
     ].join('\n'),
-    options: [{attributes: {when: 'never'}}]
+    options: [{attributes: {when: 'never'}}],
+    parser: parsers.BABEL_ESLINT
   }, {
     code: [
       '<App {',
@@ -486,9 +487,6 @@ ruleTester.run('jsx-curly-spacing', rule, {
   }, {
     code: '<App foo={ bar }>{bar}</App>',
     options: [{attributes: {when: 'always'}}]
-  }, {
-    code: '<App foo={ bar }>{bar}</App>',
-    options: [{attributes: {when: 'always'}}]
   }, {
     code: [
       '<App foo={ 42 } { ...bar } baz={{ 4: 2 }}>',
@@ -630,7 +628,8 @@ ruleTester.run('jsx-curly-spacing', rule, {
       '...bar',
       '} />;'
     ].join('\n'),
-    options: ['always']
+    options: ['always'],
+    parser: parsers.BABEL_ESLINT
   }, {
     code: [
       '<App {',

tests/lib/rules/jsx-no-undef.js

@@ -35,7 +35,8 @@ ruleTester.run('jsx-no-undef', rule, {
   valid: [{
     code: '/*eslint no-undef:1*/ var React, App; React.render(<App />);'
   }, {
-    code: '/*eslint no-undef:1*/ var React, App; React.render(<App />);'
+    code: '/*eslint no-undef:1*/ var React, App; React.render(<App />);',
+    parser: parsers.BABEL_ESLINT
   }, {
     code: '/*eslint no-undef:1*/ var React; React.render(<img />);'
   }, {

tests/lib/rules/jsx-one-expression-per-line.js

@@ -522,23 +522,6 @@ ruleTester.run('jsx-one-expression-per-line', rule, {
     ].join('\n'),
     errors: [{message: '` bar` must be placed on a new line'}],
     parserOptions
-  }, {
-    code: [
-      '<div>',
-      '  foo {"bar"}',
-      '</div>'
-    ].join('\n'),
-    output: [
-      '<div>',
-      '  foo ',
-      '{\' \'}',
-      '{"bar"}',
-      '</div>'
-    ].join('\n'),
-    errors: [
-      {message: '`{"bar"}` must be placed on a new line'}
-    ],
-    parserOptions
   }, {
     code: [
       '<div>',
@@ -705,7 +688,8 @@ ruleTester.run('jsx-one-expression-per-line', rule, {
       '</App>'
     ].join('\n'),
     errors: [{message: '`Foo` must be placed on a new line'}],
-    parserOptions
+    parserOptions,
+    parser: parsers.BABEL_ESLINT
   }, {
     code: [
       '<App>',

tests/lib/rules/jsx-pascal-case.js

@@ -12,6 +12,8 @@
 const RuleTester = require('eslint').RuleTester;
 const rule = require('../../../lib/rules/jsx-pascal-case');
 
+const parsers = require('../../helpers/parsers');
+
 const parserOptions = {
   ecmaVersion: 2018,
   sourceType: 'module',
@@ -46,6 +48,9 @@ ruleTester.run('jsx-pascal-case', rule, {
     code: '<T3stComp0nent />'
   }, {
     code: '<T />'
+  }, {
+    code: '<T />',
+    parser: parsers.BABEL_ESLINT
   }, {
     code: '<YMCA />',
     options: [{allowAllCaps: true}]
@@ -59,8 +64,6 @@ ruleTester.run('jsx-pascal-case', rule, {
   }, {
     code: '<IGNORED />',
     options: [{ignore: ['IGNORED']}]
-  }, {
-    code: '<T />'
   }, {
     code: '<$ />'
   }, {

tests/lib/rules/jsx-wrap-multilines.js

@@ -1083,7 +1083,7 @@ ruleTester.run('jsx-wrap-multilines', rule, {
       ]
     }, {
       code: DECLARATION_TERNARY_PAREN_FRAGMENT,
-      parser: parsers.BABEL_ESLINT,
+      parser: parsers.TYPESCRIPT_ESLINT,
       output: addNewLineSymbols(DECLARATION_TERNARY_PAREN_FRAGMENT),
       options: [{declaration: 'parens-new-line'}],
       errors: [

tests/lib/rules/no-redundant-should-component-update.js

@@ -44,22 +44,23 @@ ruleTester.run('no-redundant-should-component-update', rule, {
     {
       code: `
         class Foo extends React.Component {
-          shouldComponentUpdate = () => {
+          shouldComponentUpdate() {
             return true;
           }
         }
       `,
-      parser: parsers.BABEL_ESLINT,
-      parserOptions
+      parserOptions,
+      parser: parsers.BABEL_ESLINT
     },
     {
       code: `
         class Foo extends React.Component {
-          shouldComponentUpdate() {
+          shouldComponentUpdate = () => {
             return true;
           }
         }
       `,
+      parser: parsers.BABEL_ESLINT,
       parserOptions
     },
     {

tests/lib/rules/no-typos.js

@@ -333,19 +333,6 @@ ruleTester.run('no-typos', rule, {
    `,
     parser: parsers.BABEL_ESLINT,
     parserOptions
-  }, {
-    code: `
-      import PropTypes from "prop-types";
-      class Component extends React.Component {};
-      Component.propTypes = {
-        a: PropTypes.oneOf([
-          'hello',
-          'hi'
-        ])
-      }
-   `,
-    parser: parsers.BABEL_ESLINT,
-    parserOptions
   }, {
     code: `
       import PropTypes from "prop-types";
@@ -406,21 +393,6 @@ ruleTester.run('no-typos', rule, {
       }
    `,
     parserOptions
-  }, {
-    code: `
-      import PropTypes from "prop-types";
-      class Component extends React.Component {};
-      Component.childContextTypes = {
-        a: PropTypes.string,
-        b: PropTypes.string.isRequired,
-        c: PropTypes.shape({
-          d: PropTypes.string,
-          e: PropTypes.number.isRequired,
-        }).isRequired
-      }
-   `,
-    parser: parsers.BABEL_ESLINT,
-    parserOptions
   }, {
     code: `
       import PropTypes from "prop-types";
@@ -1366,6 +1338,7 @@ ruleTester.run('no-typos', rule, {
        }).isrequired
      }
     `,
+    parser: parsers.BABEL_ESLINT,
     parserOptions,
     errors: [{
       message: 'Typo in prop type chain qualifier: isrequired'

tests/lib/rules/no-unused-prop-types.js

@@ -5025,40 +5025,6 @@ ruleTester.run('no-unused-prop-types', rule, {
       errors: [{
         message: '\'lastname\' PropType is defined but prop is never used'
       }]
-    }, {
-      code: [
-        'type Person = {',
-        '  ...data,',
-        '  lastname: string',
-        '};',
-        'class Hello extends React.Component {',
-        '  props: Person;',
-        '  render () {',
-        '    return <div>Hello {this.props.firstname}</div>;',
-        '  }',
-        '}'
-      ].join('\n'),
-      parser: parsers.BABEL_ESLINT,
-      errors: [{
-        message: '\'lastname\' PropType is defined but prop is never used'
-      }]
-    }, {
-      code: [
-        'type Person = {|',
-        '  ...data,',
-        '  lastname: string',
-        '|};',
-        'class Hello extends React.Component {',
-        '  props: Person;',
-        '  render () {',
-        '    return <div>Hello {this.props.firstname}</div>;',
-        '  }',
-        '}'
-      ].join('\n'),
-      parser: parsers.BABEL_ESLINT,
-      errors: [{
-        message: '\'lastname\' PropType is defined but prop is never used'
-      }]
     }, {
       code: [
         'class Hello extends React.Component {',

tests/lib/rules/prop-types.js

@@ -1448,7 +1448,8 @@ ruleTester.run('prop-types', rule, {
         '  }',
         '});'
       ].join('\n'),
-      options: [{skipUndeclared: true}]
+      options: [{skipUndeclared: true}],
+      parser: parsers.BABEL_ESLINT
     }, {
       code: [
         'class Hello extends React.Component {',