Stop trying to use std::filesystem.
#1109
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes all std::filesystem usage from libpqxx due to portability concerns and implementation complexities. The library no longer provides support for std::filesystem::path in its APIs.
- Removed
std::filesystem::pathconstructor fromzviewclass - Removed test coverage for
std::filesystem::pathsupport - Updated documentation to clarify that libpqxx no longer uses
std::filesystem
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test_blob.cxx | Removed #include <filesystem> and the test function test_blob_accepts_std_filesystem_path() along with its registration |
| include/pqxx/zview.hxx | Removed #include <filesystem> and the constructor accepting std::filesystem::path |
| UPGRADING.md | Updated build changes section to clarify that libpqxx itself no longer uses std::filesystem |
The changes are clean, consistent, and complete. All references to std::filesystem have been properly removed from the API surface, tests, and documentation. The removal is straightforward - the zview class previously offered a convenience constructor for std::filesystem::path (only on non-Windows platforms), and this has been cleanly removed along with its test coverage. Users can still pass file paths as C-style strings or std::string objects to functions that accept zview.
There were problems with this that I couldn't figure out, and from more reading, I get the impression that there's nobody designing it who does know exactly how it's supposed to work. There's no magic solution to portability problems there, just new and unknown intricacies to replace the old, somewhat-known ones.
1 participant
There were problems with this that I couldn't figure out, and from more reading, I get the impression that there's nobody designing it who does know exactly how it's supposed to work. There's no magic solution to portability problems there, just new and unknown intricacies to replace the old, somewhat-known ones.