-
Notifications
You must be signed in to change notification settings - Fork 11
Renderer, format and path API #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Your points are very valid, but even after thinking about it I don't see a way to solve the inconsistencies without going back to a "renderer" or "output" argument. This would mean that instead of This would be more like the previous API, but maybe it would cause less confusion ? @wirhabenzeit, @harrylojames any feedback would be welcome if you have any. |
@juba To me this sounds like a good idea! Actually the
|
@wirhabenzeit Indeed, I also thought that
Thanks for your feedback ! |
@juba The above all seems reasonable but apologies I've looked through the previous discussion and still feel as though I've missed a key detail! What's stopping us from having just the arguments |
@harrylojames I get your point but I think there are cases where you would want to specify an output format even when not directly exporting to a file. I think of notebook exports (for example if you commit an |
@juba @harrylojames I agree that is useful to have svg or png output also in notebooks. Some platforms displaying |
New version of Closing this for now, don't hesitate to open a new issue for further discussion. |
Originally posted by @wirhabenzeit in #32 (comment)
The text was updated successfully, but these errors were encountered: