Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up stale user/group quota entries (those with no limits and no usage) from Redis, and skips displaying quota entries with no limits set when listing quotas.
Changes:
- Skip user/group quota entries with
MaxSpace=-1andMaxInodes=-1when listing quotas inhandleQuotaList - In Redis
doLoadQuotas, delete stale quota entries that have no limits and zero usage - In Redis
doFlushQuotas, useHSetNXto create a placeholder quota entry (-1, -1) when flushing usage increments, ensuring the quota key exists for scanning
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/meta/quota.go | Filter out user/group quotas with no limits from listing results |
| pkg/meta/redis.go | Delete stale no-limit/no-usage quota entries during load; create placeholder quota entries during flush with HSetNX |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
70a3d28 to
9e2ce5a
Compare
22fda82 to
a227e67
Compare
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6737 +/- ##
===========================================
- Coverage 48.70% 22.77% -25.93%
===========================================
Files 133 31 -102
Lines 44260 22493 -21767
===========================================
- Hits 21555 5123 -16432
+ Misses 20204 16798 -3406
+ Partials 2501 572 -1929 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jiefenghuang
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

rel: #6722