Skip to content

Remove arguments of _forward_eval_ϵ #2736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

blegat
Copy link
Member

@blegat blegat commented Apr 25, 2025

They are always the same anyway. I wonder if there is any performance benefit of saving these interpret calls. Is there a standard benchmark used for checking for regressions ?
Maybe https://github.com/lanl-ansi/rosetta-opf/blob/main/jump.jl ?

@odow
Copy link
Member

odow commented Apr 25, 2025

@odow
Copy link
Member

odow commented Apr 25, 2025

Or build that model and then manually evaluate the Hessian with MOI.eval_hessian_lagrangian etc.

@odow
Copy link
Member

odow commented Apr 25, 2025

When I refactored this out of JuMP, I tried to make the fewest possible changes. The code can be cleaned up lots.

@blegat
Copy link
Member Author

blegat commented Apr 25, 2025

Or build that model and then manually evaluate the Hessian with MOI.eval_hessian_lagrangian etc.

Yes, we could add a reduced version to MOI.Benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants