Skip to content

Conversation

@skst
Copy link

@skst skst commented Feb 27, 2025

This PR fixes #17.

  • The Expiration property was returning an Unspecified DateTime type. Added the AdjustToUniversal style to Parse.
  • Convert DateTime passed to ExpirationDate to UTC before comparing with Expiration property (which is UTC).
  • Added a validation to Expiration.set to ensure the incoming type is not Unspecified.
  • Added a validation to ExpiresAt to ensure the incoming type is not Unspecified.
  • Added more unit tests around ExpiresAt and Expiration.
  • All unit tests pass.

This is my first pull request ever. 🙂 I tried to add relevant tests and to maintain the project's coding style (indents, spaces not tabs, etc.). If I introduced an error or missed something, please let me know, and I will be happy to correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expiration Date is not correctly compared

1 participant