Repository navigation
Fix IReplyAbortContent type - #2981
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 70ae122 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Author
|
See #2982 for CI fix |
agoose77
reviewed
Jul 1, 2026
| } | ||
| }; | ||
| let status: 'abort' | 'error' | 'ok' | undefined; | ||
| let status: 'abort' | 'aborted' | 'error' | 'ok' | undefined; |
Contributor
There was a problem hiding this comment.
Can we just pull the type from the upstream?
Collaborator
Author
There was a problem hiding this comment.
That's a good idea!
@jupyterlab/services@7.6 widened IReplyAbortContent.status to 'abort' | 'aborted'; the local variable type needs to match.
Better than specifying by hand, like we did before, which can get out of sync.
stefanv
force-pushed
the
fix-aborted-status
branch
from
July 3, 2026 05:47
70ae122 to
2c1008a
Compare
Collaborator
Author
|
@agoose77 Now implements your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jupyterlab/services@7.6 widened
IReplyAbortContent.statusto'abort' | 'aborted'; the local variable type needs to match.