Updated job definition models, handlers, and scheduler apis#45
Merged
3coins merged 5 commits intojupyter-server:mainfrom Oct 5, 2022
Merged
Updated job definition models, handlers, and scheduler apis#453coins merged 5 commits intojupyter-server:mainfrom
3coins merged 5 commits intojupyter-server:mainfrom
Conversation
Collaborator
3coins
commented
Sep 26, 2022
3coins
commented
- Updated models to support job definition
- Added scheduler apis for job definitions
- Added handlers for job definition REST apis
Contributor
|
|
3coins
force-pushed
the
job-definition-models
branch
from
8a89ec0 to
afbf3f6
Compare
Collaborator
Author
|
Rebased from main, added async apis support. |
Collaborator
|
Out of curiosity, what is the set of possible values for |
JasonWeill
approved these changes
Oct 1, 2022
Collaborator
Author
Correct. |
dlqqq
requested changes
Oct 3, 2022
Merged
3coins
force-pushed
the
job-definition-models
branch
from
afbf3f6 to
8806290
Compare
ellisonbg
requested changes
Oct 4, 2022
Contributor
ellisonbg
left a comment
ellisonbg
left a comment
There was a problem hiding this comment.
Overall, this looks good, left some inline comments.
This was referenced Oct 4, 2022
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
3coins
force-pushed
the
job-definition-models
branch
2 times, most recently
from
5a5ae3e to
1653912
Compare
Collaborator
Author
|
Made all updates as per feedback. Merging the changes. |
3coins
force-pushed
the
job-definition-models
branch
from
1653912 to
a4785d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.