Serialise NumPy arrays as any other array #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
requested changes
Feb 7, 2023
vthemelis
force-pushed
the
np-array
branch
8 times, most recently
from
d151e3e to
1f7ce2f
Compare
|
@martinRenou, does this look okay to merge now? |
martinRenou
force-pushed
the
np-array
branch
from
43405e9 to
38b03df
Compare
|
@martinRenou , thanks for looking into this again. It looks like the Is it okay if I merge this PR in the meantime or shall we fix the build first? |
Also: * Simplify the _data_to_json function in terms of branching; * Remove unneeded checks for int; * Eliminate unused argument of _data_to_json; Signed-off-by: Vasilis Themelis <[email protected]>
martinRenou
force-pushed
the
np-array
branch
from
38b03df to
a0d2d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vasilis Themelis [email protected]
Fixes #393
Allow showing NumPy arrays as normal arrays in the grid. There is no distinction made between normal arrays and NumPy arrays once they are serialised but I assume that this is fine as there is not difference between normal floats and NumPy floats either (say).
Added a small unit test to assert that no exception is thrown when initialising a DataGrid object out of a DataFrame that includes np.array objects of various shapes.
Also:
I also noticed that ipydatagrid flattens arrays before showing them on the grid. I might change that on a separate PR.