Fix build for latest yarn/jlpm #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vthemelis
force-pushed
the
fix-build-2
branch
7 times, most recently
from
b55ff04 to
2d9bdc6
Compare
Move to jlpm to make sure we are in sync with JupyterLab quirks. Currently, jlpm is on yarn 3. To make the package work with that I had to: * Run `jlpm install` to change to the new lock file format. > ➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden. * Change the CICD step that ran Jupyter in detached mode as yarn doesn't seem to respect the `&` operator at the end of command targets any more and won't run the target in the background. * Use PnP loose mode of yarn. This one applies due to transative dependencies not complying with recent yarn rules. NB that I pinned the version of JupyterLab to below 4. Signed-off-by: Vasilis Themelis <[email protected]>
martinRenou
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to jlpm to make sure we are in sync with JupyterLab quirks.
Currently, jlpm is on yarn 3. To make the package work with that I had
to:
jlpm installto change to the new lock file format.seem to respect the
&operator at the end of command targets anymore and won't run the target in the background.
dependencies not complying with recent yarn rules.
This is a duplicate of #418 which I accidentally closed.