Implement set_row_value method #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
force-pushed
the
row_data_set
branch
3 times, most recently
from
1570ff0 to
201f95d
Compare
martinRenou
force-pushed
the
row_data_set
branch
from
201f95d to
726d69f
Compare
|
Thanks for the review! Will merge as soon as the patch release is out. |
Signed-off-by: martinRenou <[email protected]>
martinRenou
force-pushed
the
row_data_set
branch
from
726d69f to
fdf632e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Fix #352
Describe your changes
An equivalent to the current
set_cell_valuemethod, but for setting entire rows.Testing performed
Manual Notebook tests + adding a unit test in JS
Additional context
For users, it's more convenient/performant to have this kind of APIs than having to call
set_cell_valuemany times. We may want to implement the equivalent for columns at some point.