Skip to content

Add options to menu #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

gjmooney
Copy link

Issue number of the reported bug or feature request: #

Describe your changes
Added several option to the column context menu

  • Option to clear sort selection
  • Option to copy selection to the clipboard
  • Option to download selection as a CSV
  • Option to download the entire table as a CSV
  • Option to clear current selection
  • Added separators between sections of the menu

Testing performed
Since this is mostly just adding UI elements for existing capabilities only manual testing was performed in addition to running to the current test suite

Additional context
Selection based options are greyed out when there is no current selection

@gjmooney gjmooney force-pushed the add_options_to_menu branch 4 times, most recently from a4807f3 to 5d4bcbd Compare February 27, 2024 09:59
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I have a couple of small suggestions

@martinRenou
Copy link
Member

Bot update galata references

@martinRenou
Copy link
Member

CI failure is fixed in #482

Let's merge and iterate, thanks!

@martinRenou martinRenou merged commit d4a26f1 into jupyter-widgets:main Feb 29, 2024
@gjmooney gjmooney deleted the add_options_to_menu branch February 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants