Support 'zebra stripes' for rows or columns #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfmark
force-pushed
the
zebra-rows-and-cols
branch
from
1c5ab2d to
8a0722b
Compare
|
Great! Thanks for looking into implementing this! Changes look great to me, just a suggestion, would |
Signed-off-by: tfmark <[email protected]>
Signed-off-by: tfmark <[email protected]>
tfmark
force-pushed
the
zebra-rows-and-cols
branch
from
5e0bdc7 to
4ba0b14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #379
Describe your changes
I've tried to tackle the issue by leveraging the DataGrid
rowBackgroundColor/columnBackgroundColorfunctionality.Testing performed
I've tested locally spinning up a Jupyter lab per the instructions in the README.
Additional context
rows:
columns:
dark mode:
Note: The "zebra striping" terminology comes from the underlying DataGrid, I don't know if there is a better name for it, but I couldn't think of one :)