Skip to content

Make cluster "bubbles" ignorable by Geoman #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 1 commit into from
Jun 4, 2025
+23 −1
Merged

Make cluster "bubbles" ignorable by Geoman #1249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion python/jupyter_leaflet/src/layers/MarkerCluster.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,29 @@ export class LeafletMarkerClusterView extends LeafletLayerView {

create_obj() {
const options = this.get_options();
this.obj = L.markerClusterGroup(options);

// Intercept the creation of the cluster group to disable leaflet.pm
// (so that GeomanDrawControl will not be able to edit it)
const clusterGroup = L.markerClusterGroup(options);
const originalAddLayer = (clusterGroup as any)._featureGroup.addLayer;
(clusterGroup as any)._featureGroup.addLayer = function (layer: L.Layer) {
if (
// A cluster "bubble" is a marker with a child count
layer instanceof L.Marker &&
typeof (layer as any).getChildCount === 'function'
) {
(layer as any).pmIgnore = true;
// Disable the leaflet.pm functionality for the cluster bubble
if ((layer as any).pm) {
(layer as any).pm.disable();
delete (layer as any).pm;
}
}

return originalAddLayer.call(this, layer);
};
this.obj = clusterGroup;

this.marker_views = new ViewList(
this.add_layer_model,
this.remove_layer_view,
Expand Down
Loading