Update image_video_overlay.rst #664
Conversation
|
Thanks a lot! |
|
Fix #120 |
| @@ -44,6 +44,6 @@ Attributes | |||
| =========== ======================== === | |||
| Attribute Default Value Doc | |||
| =========== ======================== === | |||
| url "" An http url to the footage or a relative path to a local file (image/video). Note that absolute local paths are not supported. | |||
| url "" An http url to the footage or a relative path to a local file (image/video). Note that absolute local paths are not supported (e.g. ‘image.png’ or ‘files/working_dir/image.png’ in JupyterLab). | |||
There was a problem hiding this comment.
I don't quite understand, this makes it not clear if image.png and files/working_dir/image.png are supported or not, and in JupyterLab or not.
There was a problem hiding this comment.
There are 2 spaces in: "supported ("
There was a problem hiding this comment.
Ok thanks for the comment I just made another PR to improve this let me know if it is ok.
New text:
An http url to the footage or a relative path to a local file (image/video, e.g. ‘image.png’ or ‘files/working_dir/image.png’ in JupyterLab). Note that absolute local paths are not supported.
There was a problem hiding this comment.
Ok let's close this one then.
There was a problem hiding this comment.
You didn't have to open a new PR, you could push new commits to this one.
There was a problem hiding this comment.
Ok sorry, just noticed it.
Thanks
|
Replaced by #665 |
Improve documentation for image_video_overlay