Skip to content

7.2 Release plans #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
9 of 10 tasks
jasongrout opened this issue Mar 19, 2018 · 20 comments
Closed
9 of 10 tasks

7.2 Release plans #2000

jasongrout opened this issue Mar 19, 2018 · 20 comments
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Member

jasongrout commented Mar 19, 2018

I just created a 7.2 milestone with all of our completed patch and minor milestone issues/PRs. I added a few more I'll look at today or tomorrow: https://github.com/jupyter-widgets/ipywidgets/milestone/25

@jasongrout jasongrout added this to the 7.2 milestone Mar 19, 2018
@jasongrout
Copy link
Member Author

CC @jupyter-widgets/jupyter-widgets

@mwcraig
Copy link
Contributor

mwcraig commented Mar 21, 2018

Just took a quick look over the milestoned issues/PRs and looks good. Let me know if you want me to review anything.

@stonebig
Copy link
Contributor

will it be compatible with jupyterlab-beta2 ? it's said beta2 breaks compatibility with beta1

@jasongrout
Copy link
Member Author

The python ipywidgets 7.2 library will be compatible (it is versioned independently of jupyterlab). The Javascript jupyterlab manager will be updated when JLab beta 2 is released to be compatible.

@stonebig
Copy link
Contributor

ok, thanks for the information.

@jasongrout
Copy link
Member Author

jasongrout commented Mar 29, 2018

Sample release notes:

It has been 91 days since the last release, 7.1.0. In this release, we closed 20 issues and 44 pull requests with 187 commits touching 77 files, including 135 non-merge commits.

We'd like to thank the following contributors to the ipywidgets codebase in this repository. We had 18 contributors, of which 13 are new contributors (denoted with a *).

*Anand Chitipothu
*Antonino Ingargiola
*DougRzz
*Dustin Michels
*Fabien Vinas
Jason Grout
*Jeremy Tuloup
Maarten Breddels
*Madhu94
*Madhumitha Natarajan
Pascal Bugnion
*Paul Ganssle
*Romain Primet
*Ryan Morshead
*Sebastian Gutsche
*Stephanie Stattel
Sylvain Corlay
Vidar Tonaas Fauske

Also of particular note, 39 "reference" issues were closed in this time period. These issues archive answered questions and other discussions with community members, and represent a tremendous amount of effort to engage with the community.

@jasongrout
Copy link
Member Author

@jupyter-widgets/jupyter-widgets - As mentioned on gitter, my plan is to finish checking the examples and the documentation today, then release 7.2.0. Any objections?

@jasongrout
Copy link
Member Author

jasongrout commented Mar 30, 2018

I uploaded the js packages to npm and ipywidgets 7.2.0, and widgetsnbextension 3.2.0 to pypi. Please test @jupyter-widgets/jupyter-widgets.

@mwcraig (or someone in Europe, as they are likely up now :) - would you mind doing the conda-forge update? The hashes are in the release commit message: 41064fc

@jasongrout
Copy link
Member Author

I'll let people test this for a bit, then we can publish the release notes and make an announcement.

@jasongrout
Copy link
Member Author

I did verify that a simple pip install makes the widget list notebook work in the classic notebook and jupyterlab. And we don't have any more enable step with pip! Hooray!

@pbugnion
Copy link
Member

pbugnion commented Mar 30, 2018

Thanks for doing the release!

I've started the conda-forge PRs:

At the moment, we still have the widgetsnbextension enable step in conda-forge. Presumably, we want to keep this until we can mandate notebook v5.3.0?

@maartenbreddels
Copy link
Member

Yes we should keep it I think, but we should reconsider widgetsnbextension disable, since that leaves the extension disabled (instead of removing the entry from the notebook.json). I think we should simply not disable it, or do a python -c "..." oneliner to remove the entry from notebook.json

@maartenbreddels
Copy link
Member

And great work again Jason!

@pbugnion
Copy link
Member

Would the one-liner just read in notebook.json, change the JSON and save it again (e.g. using the json module), or are there higher-level libraries we could use?

I'll remove the widgetsnbextension disable for now, and we can revisit to do more complex logic in a separate release.

@maartenbreddels
Copy link
Member

maartenbreddels commented Mar 30, 2018 via email

@pbugnion
Copy link
Member

pbugnion commented Mar 30, 2018

I actually don't have permissions to merge the nbextension PR for conda. It looks ready for merging, though. Once that's merged, I can submit the ipywidgets-feedstock PR (or someone else if they get there first).

widgetsnbextension-feedstock PR here.

@maartenbreddels
Copy link
Member

Relying on notebook module as much as possible, and that the new argument read_directory=False is happily ignored for notebook version < 5.3, this should do the job:

python -c "import os; import notebook.nbextensions as nbe; import notebook.config_manager as cm; config = cm.BaseJSONConfigManager(config_dir=os.path.join(nbe._get_config_dir(sys_prefix=True), 'nbconfig'), read_directory=False); state = config.get('notebook'); state['load_extensions'].pop('jupyter-js-widgets/extension', None); config.set('notebook', state)"

@maartenbreddels
Copy link
Member

In case load_extensions is not present, this is saver:
python -c "import os; import notebook.nbextensions as nbe; import notebook.config_manager as cm; config = cm.BaseJSONConfigManager(config_dir=os.path.join(nbe._get_config_dir(sys_prefix=True), 'nbconfig'), read_directory=False); state = config.get('notebook'); state.get('load_extensions', {}).pop('jupyter-js-widgets/extension', None); config.set('notebook', state)"

@pbugnion
Copy link
Member

pbugnion commented Apr 1, 2018

Both ipywidgets and widgetsnbextension feedstocks are now merged, thanks!

For reference, the widgetsnbextension recipe has been changed so that, on uninstalling, the entry is completely removed from the notebook.json config file. Thus, running:

conda install ipywidgets -c conda-forge
conda uninstall ipywidgets widgetsnbextension

leaves your sys-prefix notebook.json config unchanged. See this PR for the discussion details.

@jasongrout
Copy link
Member Author

Looks like all we have left is publishing a note to the mailing list, though at this point, perhaps it's a bit dated?

@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

5 participants