Skip to content

Button Icons/FontAwesome regression no longer supports fa-spin #2477

Closed
@rskabelund

Description

@rskabelund

since this was added:
https://github.com/jupyter-widgets/ipywidgets/blob/master/ipywidgets/widgets/widget_button.py#L65-L73

we are no longer able to pass in additional fa classes to specify fa-spin or fa-lg etc.

I really liked my spinning gear icon button before this change...

i.e.

from ipywidgets import Button
Button(description='Running...', icon='fa-gear fa-spin fa-lg')

it will error on the add of the DOMTokenList due to the spaces in the string
https://github.com/jupyter-widgets/ipywidgets/blob/master/packages/controls/src/widget_button.ts#L91

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueresolved-lockedClosed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions