Fix invalid readout_format in docs #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The widget list page currently displays a traceback because the readout_format for some of the sliders is set to 'i', which is not a valid d3 format (it's also not a valid Python format). Previously, this didn't result in a traceback because d3-format doesn't throw an exception when the wrong type gets passed in -- it just silently converts it to the type '', corresponding to 'either decimal or exponent notation, but trim insignificant zeros'.
|
Thanks! |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The widget list page currently displays a traceback because the readout_format
for some of the sliders is set to
'i', which is not a valid d3 format (it'salso not a valid Python format type).
Prior to PR #1550, this looked like it was working because d3-format doesn't throw
an exception when the wrong type gets passed in -- it just silently converts it
to the type
'', corresponding to 'either decimal or exponent notation, but triminsignificant zeros'.