Skip to content

Remove functions that were deprecated in 4.0.0 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2015
Merged

Remove functions that were deprecated in 4.0.0 #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb6f36b
Remove deprecated after_displayed function
jdfreder Oct 30, 2015
4c200d2
Remove deprecated create_model function
jdfreder Oct 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions ipywidgets/static/widgets/js/manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,14 +180,6 @@ define([
}
}
};

/**
* Deprecated, use `new_widget` instead.
*/
WidgetManager.prototype.create_model = function (options) {
console.warn('WidgetManager.create_model is deprecated. Use ManagerBase.new_widget');
return this.new_widget(options);
};

WidgetManager.prototype.display_model = function(msg, model, options) {
options = options || {};
Expand Down
10 changes: 0 additions & 10 deletions ipywidgets/static/widgets/js/widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,16 +534,6 @@ define(["nbextensions/widgets/widgets/js/utils",
this.model.save_changes(this.callbacks());
},

after_displayed: function (callback, context) {
/**
* Deprecated method. Calls the callback right away is the view is
* already displayed otherwise, register the callback to the 'displayed'
* event.
*/
console.log('`WidgetView.after_displayed` is deprecated. Use the WidgetView.displayed promise instead.');
this.displayed.then(_.bind(callback, context));
},

remove: function () {
// Raise a remove event when the view is removed.
WidgetView.__super__.remove.apply(this, arguments);
Expand Down