FloatRangeSlider value
logic
#2435
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update logic in setting of default
value
field of the FloatRangeSlider so that numpy arrays can be passed as inputs (see #2434). Note that this will still currently error in traitlets as atuple
is expected, but at least the error at this point is very clear: A trait error is raised:I would appreciate the ability to simply provide a 2-entry long numpy array in the
value
field. What do folks think of adding something like:to the validation of the
FloatRange
valueipywidgets/ipywidgets/widgets/widget_float.py
Lines 276 to 281 in 825dc58
or would it make more sense to do something at the traitlets level?