Skip to content

Tabbable or not tabbable #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jan 7, 2020
Merged

Conversation

zerline
Copy link
Contributor

@zerline zerline commented Dec 13, 2019

Use HTML attribute tabIndex just to make a widget tabbable or _not.
This pull request does a little refactoring as well, introducing a class SelectionView between DescriptionView and the controls.

@zerline zerline changed the title tabbable Tabbable or not tabbable Dec 13, 2019
Zerline and others added 6 commits January 6, 2020 13:43
- no more test notebook until we know where to put it.
- no more setters as they are not indispensable.
This reverts commit d3fff3c.
@vidartf vidartf merged commit 0e0c2ad into jupyter-widgets:master Jan 7, 2020
@jasongrout
Copy link
Member

@zerline - I was looking through this again, in a review of what we have in 8.0 in preparation for moving forward again. Since the controls implemented here all by default are tabbable (I think?), such as listboxes, textboxes, etc., it seems that what this adds is the ability to set the tabindex to -1, i.e., to take the control out of tab ordering. Is that the main usecase you have for it?

I'm trying to think of how to explain what this new tabbable feature does to 8.0 custom widget authors and users, and more importantly, why it is there and what a typical usecase for it is. What are you using it for?

@vidartf
Copy link
Member

vidartf commented Mar 16, 2020

Since the controls implemented here all by default are tabbable (I think?)

@jasongrout Initially the PR was only for "a bunch of ipywidgets widgets: Text, Textarea, Button, ToggleButton, Combobox, Checkbox, Dropdown and Select" (#2626). I don't think all of them are tabbable by default? I think I was the one that suggested this be exposed on the DOMWidget class instead of selectively only on those that did not have it by default.

@zerline
Copy link
Contributor Author

zerline commented Mar 24, 2020

@jasongrout @vidartf sorry I was offline.
I want to use that feature in sage-explorer, for example to make tabulation go through some clickable HTML widgets, which are not tabbable by default. Sometimes I also want to disable tabulation on Text widgets, especially when they are part of a sometimes large table of widgets that is itself part of a larger interface and the (possibly blind) user might get lost in that table. Hope I'm clear enough ..

@zerline zerline deleted the zerline/tabbable branch May 20, 2020 17:44
@lock lock bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
@jasongrout jasongrout added this to the 8.0 milestone Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants