-
Notifications
You must be signed in to change notification settings - Fork 950
Tabbable or not tabbable #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabbable or not tabbable #2640
Conversation
- no more test notebook until we know where to put it. - no more setters as they are not indispensable.
This reverts commit d3fff3c.
@zerline - I was looking through this again, in a review of what we have in 8.0 in preparation for moving forward again. Since the controls implemented here all by default are tabbable (I think?), such as listboxes, textboxes, etc., it seems that what this adds is the ability to set the tabindex to -1, i.e., to take the control out of tab ordering. Is that the main usecase you have for it? I'm trying to think of how to explain what this new tabbable feature does to 8.0 custom widget authors and users, and more importantly, why it is there and what a typical usecase for it is. What are you using it for? |
@jasongrout Initially the PR was only for "a bunch of ipywidgets widgets: Text, Textarea, Button, ToggleButton, Combobox, Checkbox, Dropdown and Select" (#2626). I don't think all of them are tabbable by default? I think I was the one that suggested this be exposed on the DOMWidget class instead of selectively only on those that did not have it by default. |
@jasongrout @vidartf sorry I was offline. |
Use HTML attribute
tabIndex
just to make a widgettabbable
or _not.This pull request does a little refactoring as well, introducing a class SelectionView between DescriptionView and the controls.