Use data-jupyter-widgets-cdn-only attribute to load modules only from CDN #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasongrout Friendly ping |
|
@jasongrout Would you have time to take a look? |
jasongrout
reviewed
Mar 10, 2020
|
|
||
| // find the data-cdn for any script tag, assuming it is only used for embed-amd.js | ||
| const scripts = document.getElementsByTagName('script'); | ||
| Array.prototype.forEach.call(scripts, (script: HTMLScriptElement) => { | ||
| cdn = script.getAttribute('data-jupyter-widgets-cdn') || cdn; | ||
| onlyCDN = | ||
| onlyCDN || script.getAttribute('data-jupyter-widgets-cdn-only') != null; |
There was a problem hiding this comment.
Can you use hasAttribute instead? https://developer.mozilla.org/en-US/docs/Web/API/Element/hasAttribute
|
Thanks! This looks okay to me. Congratulations on your first contribution to ipywidgets! |
|
Thanks @jasongrout for the review! |
lock
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2786
This PR's changes are learned from previous similar PR: 8aba183
Hi @jasongrout!
Can you help me review this?
I'm not sure how to test, because if I run
yarn test, this fails at build step already in master branch.