Update github actions and fix readthedocs #3983
Merged
+30
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
changed the title
brichet
changed the title
|
Thanks! Maybe, let's drop the Python 3.7 workflows? |
Should we do 3.8 and 3.13 ? |
|
It looks like the snapshots drifted a tiny bit but CI passed. There is no bot to update the snapshots though. We can either increase the comparison threshold to make the tests more reliable or update the snapshots manually. |
|
I'll update the snapshots, they are in the artifacts |
…I, except for documentation test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upload-artifact@v3anddownload-artifact@v3actions are deprecated and prevents the workflow to run.This PR updates it to
v4, and updates alsocheckoutaction tov4.It also fixes the documentation build by adding the sphinx configuration file in
.readthedocs.yamlconf.